lkml.org 
[lkml]   [2010]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: ocfs2: char is not always signed


2010-11-18 12:20, Milton Miller wrote:
> Commit 1c66b360fe262 (Change some lock status member in ocfs2_lock_res
> to char.) states that these fields need to be signed due to comparision
> to -1, but only changed the type from unsigned char to char. However, it
> is a compiler option if char is a signed or unsigned type. Change these
> fields to signed char so the code will work with all compilers.
>
> Signed-off-by: Milton Miller<miltonm@bga.com>
oh, sorry I don't know this. Thanks.
Acked-by: Tao Ma <tao.ma@oracle.com>
> ---
> I did not look for other fields that might be char. PowerPC compilers
> default to unsigned char, and aparently arm does as well from a quick
> google search, to name two examples.
>
> diff --git a/fs/ocfs2/ocfs2.h b/fs/ocfs2/ocfs2.h
> index 1efea36..70dd3b1 100644
> --- a/fs/ocfs2/ocfs2.h
> +++ b/fs/ocfs2/ocfs2.h
> @@ -159,9 +159,9 @@ struct ocfs2_lock_res {
> char l_name[OCFS2_LOCK_ID_MAX_LEN];
> unsigned int l_ro_holders;
> unsigned int l_ex_holders;
> - char l_level;
> - char l_requested;
> - char l_blocking;
> + signed char l_level;
> + signed char l_requested;
> + signed char l_blocking;
>
> /* Data packed - type enum ocfs2_lock_type */
> unsigned char l_type;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/


\
 
 \ /
  Last update: 2010-11-18 06:43    [W:0.104 / U:0.664 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site