lkml.org 
[lkml]   [2010]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] hwmon: (lm95241) Rewritten without using macros
From
2010/11/18 Guenter Roeck <guenter.roeck@ericsson.com>:
> Hi Davide,
>

Hi Guenter,

> Looks like you still have trouble with line wraps. You might want to get this fixed;
> having to figure out why the patch does not apply is a bit annoying.
>

You said me that attaching the patch to the mail is not correct.
First times I copy/pasted from kate, that broke tabs.
The last time I copy/pasted from kwrite, that seemed me correct (but
you're saying me that it isn't).
I'm using gmail, please explain me how to attach a patch to the e-mail.

> Moving include statements around is just a whitespace change and should be avoided.
> Also, you added a blank line at the end of the file which causes a git whitespace error
> when applying the patch.
>
> No need to retransmit. I fixed both and applied the patch with a couple of additional
> formatting changes to make the file checkpatch clean.
>
> Thanks,
> Guenter
>

I thank you,
Davide.


--
All difficult problems have a simple solution. That is wrong. [A. Einstein]


\
 
 \ /
  Last update: 2010-11-18 16:57    [W:0.068 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site