Messages in this thread | | | Date | Thu, 18 Nov 2010 16:54:05 +0100 | Subject | Re: [PATCH] hwmon: (lm95241) Rewritten without using macros | From | Davide Rizzo <> |
| |
2010/11/18 Guenter Roeck <guenter.roeck@ericsson.com>: > Hi Davide, >
Hi Guenter,
> Looks like you still have trouble with line wraps. You might want to get this fixed; > having to figure out why the patch does not apply is a bit annoying. >
You said me that attaching the patch to the mail is not correct. First times I copy/pasted from kate, that broke tabs. The last time I copy/pasted from kwrite, that seemed me correct (but you're saying me that it isn't). I'm using gmail, please explain me how to attach a patch to the e-mail.
> Moving include statements around is just a whitespace change and should be avoided. > Also, you added a blank line at the end of the file which causes a git whitespace error > when applying the patch. > > No need to retransmit. I fixed both and applied the patch with a couple of additional > formatting changes to make the file checkpatch clean. > > Thanks, > Guenter >
I thank you, Davide.
-- All difficult problems have a simple solution. That is wrong. [A. Einstein]
| |