[lkml]   [2010]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 1/2] fs: Do not dispatch FITRIM through separate super_operation
On Thu, Nov 18, 2010 at 07:19:58AM -0700, Matthew Wilcox wrote:
> I guess I was assuming that, on receiving a FALLOC_FL_PUNCH_HOLE, a
> filesystem that was TRIM-aware would pass that information down to the
> block device that it's mounted on. I strongly feel that we shouldn't
> have two interfaces to do essentially the same thing.
> I guess I'm saying that you're going to have to learn about TRIM :-)

Did you actually look Lukas FITRIM code (not the slight reordering here,
but the original one). It's the ext4 version of the batched discard
model, that is a userspace ioctl to discard free space in the

hole punching will free the blocks into the free space pool. If you do
online discard it will also get discarded, but a filesystem that has
online discard enabled doesn't need FITRIM.

 \ /
  Last update: 2010-11-18 15:31    [W:0.084 / U:1.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site