lkml.org 
[lkml]   [2010]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 13/14] x86/ticketlock: add slowpath logic
>>> On 16.11.10 at 22:08, Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> +static inline void __ticket_enter_slowpath(struct arch_spinlock *lock)
> +{
> + if (sizeof(lock->tickets.tail) == sizeof(u8))
> + asm (LOCK_PREFIX "orb %1, %0"
> + : "+m" (lock->tickets.tail)
> + : "i" (TICKET_SLOWPATH_FLAG) : "memory");
> + else
> + asm (LOCK_PREFIX "orw %1, %0"
> + : "+m" (lock->tickets.tail)
> + : "i" (TICKET_SLOWPATH_FLAG) : "memory");
> +}

Came only now to mind: Here and elsewhere, did you try using
%z0 to have gcc produce the opcode suffix character, rather
than having these somewhat ugly if()-s?

Jan



\
 
 \ /
  Last update: 2010-11-17 09:35    [W:0.141 / U:22.244 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site