Messages in this thread | | | Date | Wed, 17 Nov 2010 07:52:15 +0000 | From | "Jan Beulich" <> | Subject | Re: [PATCH, v2] x86-64: fix and clean up AMD Fam10 MMCONF enabling |
| |
>>> On 16.11.10 at 23:26, Yinghai Lu <yinghai@kernel.org> wrote: > On 11/16/2010 12:25 AM, Jan Beulich wrote: >> @@ -206,8 +200,10 @@ void __cpuinit fam10h_check_enable_mmcfg >> * with 256 buses >> */ >> get_fam10h_pci_mmconf_base(); >> - if (fam10h_pci_mmconf_base_status <= 0) >> + if (!fam10h_pci_mmconf_base) { >> + pci_probe &= ~PCI_CHECK_ENABLE_AMD_MMCONF; > > case: if no cpu mmconf reg are set by BIOS and later if BSP can not get new > base, > > this pci_probe &= line will be called for every AP...
No, because the function itself has
if (!(pci_probe & PCI_CHECK_ENABLE_AMD_MMCONF)) return;
at its very beginning.
Jan
| |