lkml.org 
[lkml]   [2010]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: linux-next: Tree for November 17
On Wed, 17 Nov 2010 09:59:20 -0800 Randy Dunlap <randy.dunlap@oracle.com> wrote:
>
> Why was #include <linux/smp_lock.h> removed from <linux/hardirq.h> ?
>
> I added #include <linux/smp_lock.h> to i387.h, but them mm/filemap.c build fails
> with the same error:
>
> linux-next-20101117/mm/filemap.c: In function 'iov_iter_copy_from_user_atomic':
> linux-next-20101117/mm/filemap.c:1936: error: implicit declaration of function 'kernel_locked'

Was this fixed before Linus took that patch? Also, the #include of
linux/smp_lock.h in linux/hardirq.h was the only line between #ifdef
CONFIG_PREEMPT and #endif ... was this patch even reviewed?

Maybe (after it was reviewed) it should have been given more time in
linux-next before being merged.

--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2010-11-18 00:17    [from the cache]
©2003-2011 Jasper Spaans