lkml.org 
[lkml]   [2010]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Staging: wlan-ng: p80211netdev.c cleanup
I don't want to be rude, but it's basically a kernel hacker rule that
after you introduce a bug (and your last cleanup patch did) that you
have to fix a bug to make up for it. One excellent source of easy bugs
is using static checkers.

I've found a static checker bug for you.

drivers/staging/comedi/drivers/usbdux.c +1488
usbdux_ao_inttrig(38) warn: inconsistent returns sem:&this_usbduxsub->sem:
locked (1468) unlocked (1457,1462,1479,1488)

Here are some questions to help guide you.

1) Does it look like a bug?
2) Who introduced the bug and in which commit?
Use: "git log -p" and "git blame"
If it's a real bug and you fix it, by deductive reasoning that
means you are smarter than the person who introduced it.
3) What is the return code on line 1468?
4) Is it a special case where the caller handles it differently?
Use cscope for this.
make cscope
Use "cscope -d" for speed.
Configure vim to use cscope.
:cs find c inttrig
^] takes you back a step.
cscope is an essential kernel hacking tool.
5) usbdux_ai_inttrig() is basically the same as usbdux_ao_inttrig().
Does the ai version ever return with a lock held?
6) What are the implications if we return with the lock held?
7) How is the bug triggered?
8) Can the user trigger the bug?
9) Can a regular user trigger the bug or only root?
I sometimes have to use google for this to try figure out how
people set up the permissions.
10) Should this go into the -stable kernel?

You don't have to answer all the questions, just enough to know what the
correct fix is. You can fix a different bug if you want to... It
doesn't matter so long as it is at least equal to the bug you
introduced.

regards,
dan carpenter

PS:

> - When checking skb for NULL, which one is better? (I suppose the former one)
> skb == NULL or !skb
> Rewrite occurrences of the other one for cleanup?

You shouldn't even think about changing these. But in new code then
!skb is better as Al Viro explains in this email:
http://lwn.net/Articles/331593/



\
 
 \ /
  Last update: 2010-11-17 22:35    [from the cache]
©2003-2011 Jasper Spaans