lkml.org 
[lkml]   [2010]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] add netdev led trigger
On Wed, Nov 17, 2010 at 08:58:43PM +0100, Pavel Machek wrote:
> Hi!
>
> > > > Add a netdev LED trigger for all Blinkenlights lovers...
> > > > Originally taken from https://dev.openwrt.org/ticket/2776
> > > > Slightly updated for 2.6.24 by Mickey Lauer <mickey@openmoko.org>
> > > > and for 2.6.36 by Eric Cooper <ecc@cmu.edu>
> > >
> > > Nice!
> > >
> > > > +/*
> > > > + * Configurable sysfs attributes:
> > > > + *
> > > > + * device_name - network device name to monitor
> > > > + *
> > > > + * interval - duration of LED blink, in milliseconds
> > >
> > > This needs to go to Doc/ somewhere.
> >
> > Documentation/ABI is the correct place for it.
>
> I was hoping you'd comment on the ABI itself, too. It uses
>
> echo "foo bar baz" > file
>
> to enable/disable specific events to be "displayed". More traditional
> interface would be
>
> echo disable > file_foo

Sorry, yes, I missed that. It would be obvious that the api was
incorrect once it was documented in the correct format :)

thanks,

greg k-h


\
 
 \ /
  Last update: 2010-11-17 21:03    [W:0.101 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site