Messages in this thread | | | Date | Wed, 17 Nov 2010 14:01:25 -0500 | From | Ted Ts'o <> | Subject | Re: [patch] ext4: missing unlock in ext4_clear_request_list() |
| |
On Wed, Nov 17, 2010 at 08:07:32AM +0300, Dan Carpenter wrote: > If the the li_request_list was empty then it returned with the lock > held. Instead of adding a "goto unlock" I just removed that special > case and let it go past the empty list_for_each_safe(). > > Signed-off-by: Dan Carpenter <error27@gmail.com>
Nice catch. Thanks, I've grabbed this and put it into the ext4 patch queue and will be pushing it to Linus ASAP.
- Ted
| |