Messages in this thread | | | Date | Wed, 17 Nov 2010 13:18:46 -0500 | Subject | Re: [PATCH 1/2] Drivers: hid: Makefile: Cleaned up Makefile | From | Tracey Dent <> |
| |
On 11/17/10, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: > On Tue, Nov 16, 2010 at 10:28:19PM -0500, Tracey Dent wrote: >> On 11/15/10, Jiri Kosina <jkosina@suse.cz> wrote: >> > On Sun, 7 Nov 2010, Tracey Dent wrote: >> > >> >> Changed Makefile to use <modules>-y instead of <modules>-objs because >> >> -objs is deprecated and should now be switched. According to >> >> (documentation/kbuild/makefiles.txt). >> > >> > Actually, where exactly does this file document it? >> > >> >> It documents how it should be done in the section entitled --- 3.7 >> Compilation flags (which starts on line 284). >> > > Actually the only reference I could find is in 3.3: > > If a kernel module is built from several source files, you specify > that you want to build a module in the same way as above; however, > kbuild needs to know which object files you want to build your > module from, so you have to tell it by setting a $(<module_name>-y) > variable. > > See commit 4f8272802739f5c6ce6b0a548810a181d2f1b652 for reasoning behind > the change. >
You're right, I was thinking I changed to use ccflags-y flags. Sorry :(
> Thanks. > > -- > Dmitry >
Thanks
Tracey Dent
| |