Messages in this thread | | | Subject | Re: [PATCH v2 05/20] ARM: LPAE: Introduce L_PTE_NOEXEC and L_PTE_NOWRITE | From | Catalin Marinas <> | Date | Wed, 17 Nov 2010 17:34:42 +0000 |
| |
On Wed, 2010-11-17 at 17:32 +0000, Russell King - ARM Linux wrote: > On Wed, Nov 17, 2010 at 05:30:33PM +0000, Catalin Marinas wrote: > > On Wed, 2010-11-17 at 17:24 +0000, Russell King - ARM Linux wrote: > > > On Wed, Nov 17, 2010 at 05:22:12PM +0000, Catalin Marinas wrote: > > > > Ah, good point, that was the mask. > > > > > > > > So for dmacoherent we make sure that L_PTE_EXEC is cleared. I suspect > > > > we should now make sure that L_PTE_NOEXEC is set. For the other two, > > > > just leave them as they are. > > > > > > Already done: > > > > > > #define pgprot_dmacoherent(prot) \ > > > - __pgprot_modify(prot, L_PTE_MT_MASK|L_PTE_EXEC, L_PTE_MT_BUFFERABLE) > > > + __pgprot_modify(prot, L_PTE_MT_MASK, L_PTE_MT_BUFFERABLE|L_PTE_XN) > > > ... > > > #define pgprot_dmacoherent(prot) \ > > > - __pgprot_modify(prot, L_PTE_MT_MASK|L_PTE_EXEC, L_PTE_MT_UNCACHED) > > > + __pgprot_modify(prot, L_PTE_MT_MASK, L_PTE_MT_UNCACHED|L_PTE_XN) > > > > Are you already doing such changes? Just to avoid duplicating effort > > (and use common naming scheme). > > I did say that I had patches for all the issues I raised so far... They're > just in the process of being posted (if lists.infradead.org this time can > cope with one patch every 20 secs...)
I wasn't sure which patches, so I did the XN/RDONLY as well (not big patch though).
I'll rebase my LPAE stuff in the next days and repost.
Thanks.
-- Catalin
| |