lkml.org 
[lkml]   [2010]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 02/20] ARM: LPAE: Factor out 2-level page table definitions into separate files
On Tue, Nov 16, 2010 at 09:14:52AM +0000, Catalin Marinas wrote:
> On 15 November 2010 23:31, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
> > This should become:
> >
> > typedef struct { pteval_t pte; } pte_t;
> >
> > L_PTE_* can then be declared using linux/const.h stuff to typedef them
> > to pteval_t.
>
> I already do this for LPAE but can be done for the 2-level definitions
> for consistency.

No you don't. You define the 2nd level definitions using pmd_t which
is _wrong_. pmd_t is the type of the pmd container, not the pmd value.

> BTW, do you think it's worth adding STRICT_MM_TYPECHECKS for LPAE as
> well? It would probably spot some issues.

Definitely, because it'll throw out warnings for most of your _AT(pmd_t,)
definitions.


\
 
 \ /
  Last update: 2010-11-16 11:03    [W:0.080 / U:3.272 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site