[lkml]   [2010]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] drivers/media: nuvoton: always true expression
    Em 16-11-2010 19:54, Jarod Wilson escreveu:
    > On Tue, Nov 16, 2010 at 09:19:53PM +0100, Nicolas Kaiser wrote:
    >> I noticed that the second part of this conditional is always true.
    >> Would the intention be to strictly check on both chip_major and
    >> chip_minor?
    >> Signed-off-by: Nicolas Kaiser <>
    > Hrm, yeah, looks like I screwed that one up. You're correct, the intention
    > was to make sure we have a matching chip id high and one or the other of
    > the chip id low values.
    > Acked-by: Jarod Wilson <>
    I wander if it wouldn't be good to print something if the probe fails due to
    the wrong chip ID. It may help if someone complain about a different


     \ /
      Last update: 2010-11-17 02:55    [W:0.018 / U:2.756 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site