Messages in this thread Patch in this message | | | Subject | [PATCH 1/5] ASoC: Fix incorrect kfree in ad1836_probe error path | From | Axel Lin <> | Date | Tue, 16 Nov 2010 16:08:00 +0800 |
| |
We allocated memory for ad1836 in ad1836_spi_probe, and will free the memory in either ad1836_spi_probe error path or ad1836_spi_remove.
Thus we should not call kfree(ad1836) in ad1836_probe, otherwise we have double free of ad1836.
Signed-off-by: Axel Lin <axel.lin@gmail.com> --- sound/soc/codecs/ad1836.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/ad1836.c b/sound/soc/codecs/ad1836.c index c71b05d..e5d3db9 100644 --- a/sound/soc/codecs/ad1836.c +++ b/sound/soc/codecs/ad1836.c @@ -228,7 +228,6 @@ static int ad1836_probe(struct snd_soc_codec *codec) if (ret < 0) { dev_err(codec->dev, "failed to set cache I/O: %d\n", ret); - kfree(ad1836); return ret; } -- 1.7.2
| |