lkml.org 
[lkml]   [2010]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/6] ce4100: Add support for CE4100 EHCI IP block to EHCI driver
On Wed, Nov 10, 2010 at 01:51:17PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 10-11-2010 5:36, Alan Stern wrote:
>
> >>In a previous patch in this series GregKH asked that the PCI ID not be added
> >>to pci_ids.h for ID's that are only used by a single file.
> >>Here is an updated version of the EHCI controller patch.
>
> >>Subject: [PATCH] ce4100: Add support for CE4100 EHCI IP block to EHCI driver
>
> >>This patch adds support for the EHCI IP block present on the Intel
> >>CE4100.
>
> >>Signed-off-by: Dirk Brandewie<dirk.brandewie@gmail.com>
> >>CC: linux-usb@vger.kernel.org
> >>CC: David Brownell<dbrownell@users.sourceforge.net>
> >>---
> >> drivers/usb/host/ehci-pci.c | 4 ++++
> >> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> >>diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c
> >>index a1e8d27..da2b196 100644
> >>--- a/drivers/usb/host/ehci-pci.c
> >>+++ b/drivers/usb/host/ehci-pci.c
> >>@@ -124,6 +124,10 @@ static int ehci_pci_setup(struct usb_hcd *hcd)
> >> ehci_info(ehci, "disable lpm for langwell/penwell\n");
> >> ehci->has_lpm = 0;
> >> }
> >>+ if (pdev->device == 0x2e70) {
> >>+ hcd->has_tt = 1;
> >>+ tdi_reset(ehci);
> >>+ }
>
> >I think Greg meant that it's okay to use a symbolic constant for the
> >PCI ID (it helps tell people what hardware is being handled). Just
> >don't add that constant to the pci_ids.h file.
>
> Or at least you need a comment naming the hardware that this ID belongs to.

I agree, something a bit better than just the device id might be nice
here.

Dirk, care to redo this one and your serial one, with that idea?

thanks,

greg k-h


\
 
 \ /
  Last update: 2010-11-16 23:01    [W:0.796 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site