lkml.org 
[lkml]   [2010]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [RFC/RFT PATCH v3] sched: automated per tty task groups
    From
    Date
    On Tue, 2010-11-16 at 15:01 +0100, Peter Zijlstra wrote:
    > On Mon, 2010-11-15 at 14:25 -0700, Mike Galbraith wrote:
    > > > > + if (p->flags & PF_EXITING)
    > > > > + return false;
    > > >
    > > > Hmm, why? Perhaps PF_EXITING was needed in the previous version to
    > > > avoid the race with release_task(). But now it is always safe to
    > > > use signal->autogroup.
    > >
    > > That came into existence when I stress tested previous version in
    > > PREEMPT_RT (boom). I see no good reason to bother an exiting task
    > > though, so would prefer to leave it as is.
    >
    > PREEMPT_RT has a slightly different exit path IIRC. If that was the only
    > thing you saw it explode on we could leave the check out for now and
    > revisit it in the -rt patches when and if it pops up. Hmm?

    Yeah, I'm going to whack it. (and add your lockdep thingy)

    -Mike




    \
     
     \ /
      Last update: 2010-11-16 15:23    [W:0.040 / U:7.356 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site