Messages in this thread | | | From | Linus Torvalds <> | Date | Mon, 15 Nov 2010 09:41:25 -0800 | Subject | Re: [PATCH] Fix dmesg_restrict build failure with CONFIG_EMBEDDED=y and CONFIG_PRINTK=n |
| |
On Mon, Nov 15, 2010 at 9:34 AM, Eric Paris <eparis@parisplace.org> wrote: > > I'm sure somebody somewhere hates it, but I was thinking something > like the attached.
I certainly like it. If the old rule should have been that you _have_ to call cap_syslog(), then just eviscerating that entirely and putting it in the generic code is definitely the right thing.
Anyway, I wanted to do -rc2 yesterday, but I don't really want this kernel build problem to remain (even if it's not a very relevant config for most people).
So if people can quickly agree on this, I'll take it and do -rc2 later today, otherwise I'll do Joe's trivial patch as a stop-gap measure pending approval for cleanup/fixing the security interfaces.
Linus
| |