Messages in this thread | | | Date | Mon, 15 Nov 2010 12:06:08 +0100 | From | Andi Kleen <> | Subject | Re: [PATCH 1/2] perf-events: Add support for supplementary event registers v2 |
| |
On Mon, Nov 15, 2010 at 12:03:28PM +0100, Stephane Eranian wrote: > On Sat, Nov 13, 2010 at 11:34 AM, Peter Zijlstra <a.p.zijlstra@chello.nl> wrote: > > On Sat, 2010-11-13 at 11:17 +0100, Andi Kleen wrote: > >> > That would assume a single event doesn't contain offcore and lbr, no? > >> > Currently the extra_reg thing assumes there's only one extra reg encoded > >> > in the config word. > >> > >> It would not be too hard to make it an array if that's needed. > > > > I don't think we want to go there anyway, one extra_reg per config value > > is fine. > > > I think offcore goes into .config, lbr goes into extra_reg. That should take > care of combinations as well.
The context switch code needs extra_reg for any extra regs including offcore, I don't want to walk the event table for that.
-Andi
-- ak@linux.intel.com -- Speaking for myself only.
| |