lkml.org 
[lkml]   [2010]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC/PATCH] usb: Add streams support to epautoconf.
On Sun, Nov 14, 2010 at 08:23:20AM +0200, Maya Erez wrote:
> + /* Get the number of required streams from the EP companion
> + * descriptor and see if the EP matches it
> + */

Close, but this isn't the proper format for multi-line comments in the
kernel. Please fix this.

> + if (USB_ENDPOINT_XFER_BULK == type) {

Ick, no, don't do comparisons like this. The compiler will let you know
if you acidentally get it wrong with only one '=' character, don't do
things "backward" like this just to work around stupid compilers.

thanks,

greg k-h


\
 
 \ /
  Last update: 2010-11-14 19:31    [W:0.047 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site