lkml.org 
[lkml]   [2010]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Fix dmesg_restrict build failure with CONFIG_EMBEDDED=y and CONFIG_PRINTK=n

    * Linus Torvalds <torvalds@linux-foundation.org> wrote:

    > (The diffstat says that this adds more lines than it removes, but that
    > is misleading: it is due to actually commenting the rule that checks
    > are done open-time for /proc/kmsg)
    >
    > Linus
    >
    > include/linux/security.h | 11 +++++------
    > kernel/printk.c | 15 ++++++++++++---
    > kernel/sysctl.c | 2 +-
    > security/commoncap.c | 7 +------
    > security/security.c | 4 ++--
    > security/selinux/hooks.c | 4 ++--
    > security/smack/smack_lsm.c | 4 ++--
    > 7 files changed, 25 insertions(+), 22 deletions(-)

    I gave it some testing in -tip and your patch also solves the !EMBEDDED build bug
    (and it also still restricts unprivileged dmesg output when desired), so:

    Acked-by: Ingo Molnar <mingo@elte.hu>
    Tested-by: Ingo Molnar <mingo@elte.hu>

    Thanks,

    Ingo


    \
     
     \ /
      Last update: 2010-11-14 13:39    [W:0.021 / U:29.748 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site