Messages in this thread | | | Date | Sun, 14 Nov 2010 08:52:13 +0100 | From | Sam Ravnborg <> | Subject | Re: [PATCH v2] drivers/net/tile/: on-chip network drivers for the tile architecture |
| |
> diff --git a/drivers/net/tile/Makefile b/drivers/net/tile/Makefile > new file mode 100644 > index 0000000..f634f14 > --- /dev/null > +++ b/drivers/net/tile/Makefile > @@ -0,0 +1,10 @@ > +# > +# Makefile for the TILE on-chip networking support. > +# > + > +obj-$(CONFIG_TILE_NET) += tile_net.o > +ifdef CONFIG_TILEGX > +tile_net-objs := tilegx.o mpipe.o iorpc_mpipe.o dma_queue.o > +else > +tile_net-objs := tilepro.o > +endif
The -objs syntax is deprecated these days. Preferred syntax for the above is:
ifdef CONFIG_TILEGX tile_net-y := tilegx.o mpipe.o iorpc_mpipe.o dma_queue.o else tile_net-y := tilepro.o endif
We could make this even shorter like this (assuming TILEGX is a bool): tile_net-y := tilepro.o tile_net-$(CONFIG_TILEGX) := tilegx.o mpipe.o iorpc_mpipe.o dma_queue.o
But this is less readable - so the longer version is better.
Sam
| |