lkml.org 
[lkml]   [2010]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH/RFC] netfilter: nf_conntrack_sip: Handle quirky Cisco phones
    From
    On Sun, Nov 14, 2010 at 11:57 AM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
    > Via: SIP/2.0/UDP 192.168.2.28:5060;branch=xxxxxxxx
    >
    >
    > Maybe a fix would be to use this "5060" port, instead of hardcoding it
    > like you did ?

    Just posted v2... appreciate the advice so far.

    My new code in process_sip_request() looks for an address match + port
    mismatch between the IP source and the Via: header. This is how it
    tries to detect whether we are talking directly to an afflicted Cisco
    phone. If the address doesn't match, I assume the request is passing
    through a non-SIP-aware NAT router so there is no special handling.

    Assuming we can reliably detect the "quirky phone" condition, is there
    any way to just trick Netfilter into thinking the source port was 5060
    instead of 49xxx? 3/4ths of the patch could probably be eliminated if
    we could overwrite the port number inside tuplehash.


    \
     
     \ /
      Last update: 2010-11-15 04:03    [W:0.024 / U:1.100 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site