Messages in this thread |  | | From | Linus Torvalds <> | | Date | Sun, 14 Nov 2010 16:26:47 -0800 | | Subject | Re: [RFC/RFT PATCH v3] sched: automated per tty task groups |
| |
On Sun, Nov 14, 2010 at 4:15 PM, Linus Torvalds <torvalds@linux-foundation.org> wrote: > > THAT is why I think it's so silly to try to be so strict and walk over > all processes while holding a couple of spinlocks.
Btw, let me say that I think the patch is great even with that thing in. It looks clean, the thing I'm complaining about is not a big deal, and it seems to perform very much as advertized. The difference with autogroup scheduling is very noticeable with a simple "make -j64" kernel compile.
So I really don't think it's a big deal. The sysctl handler isn't even complicated. But boy does it hurt my eyes to see a spinlock held around a "do_each_thread()". And I do get the feeling that the simplest way to fix it would be to just remove the code entirely, and just say that "enabling/disabling may be delayed for old processes with existing autogroups".
Linus
|  |