lkml.org 
[lkml]   [2010]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCHv2] OMAP: Serial: Define OMAP uart MDR1 register definitions
    Date
    Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com> writes:

    > Hi,
    >
    > On Thu, Nov 11, 2010 at 6:02 PM, Kevin Hilman
    > <khilman@deeprootsystems.com> wrote:
    >> Emeltchenko Andrei <Andrei.Emeltchenko.news@gmail.com> writes:
    >>
    >>> From: Andrei Emeltchenko <andrei.emeltchenko@nokia.com>
    >>>
    >>> Define MDR1 register serial definitions used in serial and
    >>> bluetooth drivers. Remove magic numbers there.
    >>
    >> Remove magic numbers where?  This patch doesn't remove anything.
    >
    > We have code which is not yet upstream, it will come through Bluetooth
    > subtree at some point, I am also going to remove magic in
    > omapX/serial.c drivers in the next patches.
    >
    > Do you think I need to add those patches?

    Not necessarly, but the comment should be a little more clear.
    Something "subsequent patches will remove...."

    Kevin

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-11-12 21:29    [W:0.020 / U:119.996 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site