lkml.org 
[lkml]   [2010]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCHv2] OMAP: Serial: Define OMAP uart MDR1 register definitions
    From
    Hi,

    On Thu, Nov 11, 2010 at 6:02 PM, Kevin Hilman
    <khilman@deeprootsystems.com> wrote:
    > Emeltchenko Andrei <Andrei.Emeltchenko.news@gmail.com> writes:
    >
    >> From: Andrei Emeltchenko <andrei.emeltchenko@nokia.com>
    >>
    >> Define MDR1 register serial definitions used in serial and
    >> bluetooth drivers. Remove magic numbers there.
    >
    > Remove magic numbers where?  This patch doesn't remove anything.

    We have code which is not yet upstream, it will come through Bluetooth
    subtree at some point, I am also going to remove magic in
    omapX/serial.c drivers in the next patches.

    Do you think I need to add those patches?

    >
    >> *v2   added OMAP keyword
    >
    > This info should go after the '---' as it is not needed in the final
    > git history.

    OK, will remove it.

    >
    > Kevin
    >
    >> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@nokia.com>
    >> ---
    >>  include/linux/serial_reg.h |   12 ++++++++++++
    >>  1 files changed, 12 insertions(+), 0 deletions(-)
    >>
    >> diff --git a/include/linux/serial_reg.h b/include/linux/serial_reg.h
    >> index c7a0ce1..6f38234 100644
    >> --- a/include/linux/serial_reg.h
    >> +++ b/include/linux/serial_reg.h
    >> @@ -341,5 +341,17 @@
    >>  #define UART_OMAP_SYSS               0x16    /* System status register */
    >>  #define UART_OMAP_WER                0x17    /* Wake-up enable register */
    >>
    >> +/*
    >> + * These are the definitions for the MDR1 register
    >> + */
    >> +#define UART_OMAP_MDR1_16X_MODE              0x00    /* UART 16x mode */
    >> +#define UART_OMAP_MDR1_SIR_MODE              0x01    /* SIR mode */
    >> +#define UART_OMAP_MDR1_16X_ABAUD_MODE        0x02    /* UART 16x auto-baud */
    >> +#define UART_OMAP_MDR1_13X_MODE              0x03    /* UART 13x mode */
    >> +#define UART_OMAP_MDR1_MIR_MODE              0x04    /* MIR mode */
    >> +#define UART_OMAP_MDR1_FIR_MODE              0x05    /* FIR mode */
    >> +#define UART_OMAP_MDR1_CIR_MODE              0x06    /* CIR mode */
    >> +#define UART_OMAP_MDR1_DISABLE               0x07    /* Disable (default state) */
    >> +
    >>  #endif /* _LINUX_SERIAL_REG_H */
    >
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-11-12 08:53    [W:0.023 / U:92.036 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site