lkml.org 
[lkml]   [2010]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v1.3 2/4] key: add tpm_send command
    Date
    Mimi Zohar <zohar@linux.vnet.ibm.com> wrote:

    > > > + module_put(chip->dev->driver->owner);
    > >
    > > Where's the corresponding module_get()? I suspect this should be wrapped to
    > > match tpm_chip_find_get().
    > >
    > > David
    >
    > The module_get() is in tpm_chip_find_get(), which is just a helper.
    > (It's used this way throughout tpm.c)

    I'd make a function tpm_chip_find_put() just to wrap module_put() and then
    place it with tpm_chip_find_get() in the sources. That makes it easier to see
    what's going on.

    David


    \
     
     \ /
      Last update: 2010-11-12 15:15    [W:0.022 / U:0.128 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site