lkml.org 
[lkml]   [2010]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Staging: comedi: fix coding style issue in pcmuio.c
    On Thu, Nov 11, 2010 at 11:28:12AM -0300, Damian Varayud wrote:
    > This is a patch to the pcmuio.c file that fixes up braces, overlines
    > and printk warnings found by the checkpatch.pl tool
    >
    > Signed-off-by: Ezequiel Medina <ezemed7@gmail.com>
    > ---

    Looks basically Ok, but there are some few problems with the comments.

    > #define REG_INT_PENDING 0x6
    > -#define REG_PAGELOCK 0x7 /* page selector register, upper 2 bits select a page
    > - and bits 0-5 are used to 'lock down' a particular
    > - port above to make it readonly. */
    > +#define REG_PAGELOCK 0x7/* page selector register, upper 2 bits select a page
    > + and bits 0-5 are used to 'lock down' a particular
    > + port above to make it readonly. */

    The original spacing was better.

    > struct {
    > - int asic; /* if non-negative, this subdev has an interrupt asic */
    > + int asic; /* if non-negative, this subdev has an
    > + * interrupt asic */
    > int first_chan; /* if nonnegative, the first channel id for
    > interrupts. */

    Frankly I would just leave these as is since it's barely over the 80
    char mark. But if you really want to change them then linux multi-line
    commenting style is described in Documentation/CodingStyle

    The preferred style for long (multi-line) comments is:

    /*
    * This is the preferred style for multi-line
    * comments in the Linux kernel source code.
    * Please use it consistently.
    *
    * Description: A column of asterisks on the left side,
    * with beginning and ending almost-blank lines.
    */

    Please redo the comments and resend.

    regards,
    dan carpenter




    \
     
     \ /
      Last update: 2010-11-11 23:27    [W:0.021 / U:121.220 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site