Messages in this thread | | | Date | Thu, 11 Nov 2010 21:49:26 +0100 (CET) | From | Jan Engelhardt <> | Subject | Re: [PATCH] netfilter: NF_HOOK_COND has wrong conditional |
| |
On Thursday 2010-11-11 20:09, Eric Paris wrote:
>The NF_HOOK_COND returns 0 when it shouldn't due to what I believe to be an >error in the code as the order of operations is not what was intended. C will >evalutate == before =. Which means ret is getting set to the bool result, >rather than the return value of the function call. The code says > >if (ret = function() == 1) >when it meant to say: >if ((ret = function()) == 1)
Thanks for catching. Indeed (ret = f) == 1 is desired, as can be seen in patch 2249065f4b22b493bae2caf549b86f175f33188e.
| |