lkml.org 
[lkml]   [2010]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v7] USB device driver of Topcliff PCH
Date
Hi Michal

Thank you for your comment.
I will modify.

Best regards
Toshiharu Okada (OKI SEMICONDUCTOR)
----- Original Message -----
Date: Wed, 10 Nov 2010 13:29:58 +0100
From: "Michał Nazarewicz" <m.nazarewicz@samsung.com>
>
> In that case, make it:
>
> if (list_empty(&ep->queue)) {
> if (halt) { /* halt or clear halt */
> if (ep->num == PCH_UDC_EP0)
> ep->dev->stall = 1;
> pch_udc_ep_set_stall(ep);
> pch_udc_enable_ep_interrupts(ep->dev, PCH_UDC_EPINT(ep->in, ep->num));
> } else {
> pch_udc_ep_clear_stall(ep);
> }
> ret = 0;
> } else {
> dev_dbg(&dev->pdev->dev, "%s: list not empty", __func__);
> ret = -EAGAIN;
> }
>
> Ie. no need to put "ret = 0;" twice in the code.
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-11-11 02:29    [W:0.075 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site