lkml.org 
[lkml]   [2010]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v15 00/17] Provide a zero-copy method on KVM virtio-net.
From
From: xiaohui.xin@intel.com
Date: Wed, 10 Nov 2010 17:23:28 +0800

> From: Xin Xiaohui <xiaohui.xin@intel.com>
>
>>2) The idea to key off of skb->dev in skb_release_data() is
>> fundamentally flawed since many actions can change skb->dev on you,
>> which will end up causing a leak of your external data areas.
>
> How about this one? If the destructor_arg is not a good candidate,
> then I have to add an apparent field in shinfo.

If destructor_arg is actually a net_device pointer or similar,
you will need to take a reference count on it or similar.

Which means --> good bye performance especially on SMP.

You're going to be adding new serialization points and at
least two new atomics per packet.


\
 
 \ /
  Last update: 2010-11-10 18:49    [from the cache]
©2003-2011 Jasper Spaans