lkml.org 
[lkml]   [2010]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 43 of 66] don't leave orhpaned swap cache after ksm merging
On Tue, Nov 09, 2010 at 11:49:30PM -0800, Hugh Dickins wrote:
> We did ask you back then to send in a fix separate from THP, but both
> sides then forgot about it until recently.

Correct :).

> We didn't agree on what the fix should look like. You're keen to change
> the page locking there, I didn't make a persuasive case for keeping it
> as is, yet I can see no point whatever in changing it for this swap fix.
> Could I persuade you to approve this simpler alternative?

Sure your version will work fine too. I insisted in removing the page
lock around replace_page because I didn't see the point of it and I
like strict code, but keeping it can do no harm.


\
 
 \ /
  Last update: 2010-11-10 17:13    [from the cache]
©2003-2011 Jasper Spaans