Messages in this thread | | | Date | Wed, 10 Nov 2010 14:10:46 +0100 | From | Michal Simek <> | Subject | Re: [PATCH 06/10] microblaze: convert to clocksource_register_hz/khz |
| |
John Stultz wrote: > This converts the microblaze clocksources to use clocksource_register_hz/khz > > This is untested, so any assistance in testing would be appreciated! > > CC: Michal Simek <monstr@monstr.eu> > CC: Thomas Gleixner <tglx@linutronix.de> > Signed-off-by: John Stultz <johnstul@us.ibm.com> > --- > arch/microblaze/kernel/timer.c | 6 +----- > 1 files changed, 1 insertions(+), 5 deletions(-)
I can't see any problem in it.
Tested-by: Michal Simek <monstr@monstr.eu>
> > diff --git a/arch/microblaze/kernel/timer.c b/arch/microblaze/kernel/timer.c > index a5aa33d..68ec7d1 100644 > --- a/arch/microblaze/kernel/timer.c > +++ b/arch/microblaze/kernel/timer.c > @@ -217,16 +217,12 @@ static struct clocksource clocksource_microblaze = { > .rating = 300, > .read = microblaze_read, > .mask = CLOCKSOURCE_MASK(32), > - .shift = 8, /* I can shift it */ > .flags = CLOCK_SOURCE_IS_CONTINUOUS, > }; > > static int __init microblaze_clocksource_init(void) > { > - clocksource_microblaze.mult = > - clocksource_hz2mult(timer_clock_freq, > - clocksource_microblaze.shift); > - if (clocksource_register(&clocksource_microblaze)) > + if (clocksource_register_hz(&clocksource_microblaze, timer_clock_freq)) > panic("failed to register clocksource"); > > /* stop timer1 */
-- Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/ Microblaze U-BOOT custodian
| |