lkml.org 
[lkml]   [2010]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [2.6.37-rc1, patch] r8169: fix sleeping while holding spinlock...
Daniel J Blueman <daniel.blueman@gmail.com> :
> Recent changes to the r8169 driver cause it to call
> device_set_wakeup_enable under spinlock, which may sleep.

The change is fine but the description is misleading : the r8169
driver has been issuing device_set_wakeup_enable under spinlock since
october 2008. device_set_wakeup_enable did not sleep until recently
(see f2dc0d1809ab7e0147c7e4ac837be1682f706538 for instance).

drivers/net/gianfar_ethtool.c::gfar_set_wol is broken as well when
CONFIG_PM is set.

--
Ueimor


\
 
 \ /
  Last update: 2010-11-02 00:49    [W:0.032 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site