Messages in this thread | | | Date | Mon, 1 Nov 2010 22:57:51 +0100 (CET) | From | Jesper Juhl <> | Subject | Re: [PATCH 4/4] scripts/checkpatch.pl: Add check for k.alloc GFP as first argument |
| |
On Sun, 31 Oct 2010, Joe Perches wrote:
> Signed-off-by: Joe Perches <joe@perches.com> > --- > scripts/checkpatch.pl | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index 90b54d4..114f667 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -2789,6 +2789,11 @@ sub process { > WARN("unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html\n" . $herecurr); > } > > +# check for k.alloc GFP in wrong location > + if ($line =~ /\bk[czm]alloc\s*\(\s*\(?\s*GFP_/) {
Just off the top of my head, but shouldn't this check for \s*_*GFP_ in order to catch things like __GFP_ZERO as well? And what about functions like kmalloc_node()/vmalloc_node() which may also have this problem?
> + ERROR("alloc has GFP_<level> as last argument\n" . $herecurr); > + } > + > # check for gcc specific __FUNCTION__ > if ($line =~ /__FUNCTION__/) { > WARN("__func__ should be used instead of gcc specific __FUNCTION__\n" . $herecurr); >
-- Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/ Plain text mails only, please http://www.expita.com/nomime.html Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
| |