lkml.org 
[lkml]   [2010]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 06/18] fs: Clean up inode reference counting
On Fri, Oct 08, 2010 at 06:46:43PM +1100, Dave Chinner wrote:
> > Also any chance to get an assert under a debug option the the reference
> > count really is non-zero?
>
> For iref()? Sure, but I think WARN_ON_ONCE() is better for the moment,
> though.

I don't think a WARN_ON_ONCE is too helpful - there could be all kinds
of different filesystems having that issue. Also I think a plain
WARN_ON is cheaper than a WARN_ON_ONCE and this is a rather hot
codepath.



\
 
 \ /
  Last update: 2010-10-08 10:19    [W:0.172 / U:5.204 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site