lkml.org 
[lkml]   [2010]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 04/18] fs: Implement lazy LRU updates for inodes.
On Fri, Oct 08, 2010 at 04:21:18PM +1100, Dave Chinner wrote:

> void __iget(struct inode *inode)
> {
> - if (atomic_inc_return(&inode->i_count) != 1)
> - return;
> -
> - if (!(inode->i_state & (I_DIRTY|I_SYNC)))
> - list_move(&inode->i_list, &inode_in_use);
> - percpu_counter_dec(&nr_inodes_unused);
> + atomic_inc(&inode->i_count);
> }

Umm... Are you sure we don't rely on implict barriers present in the current
version?


\
 
 \ /
  Last update: 2010-10-08 11:11    [W:0.364 / U:0.072 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site