Messages in this thread | | | Date | Fri, 08 Oct 2010 11:42:05 +0800 | From | Chen Gong <> | Subject | Re: [1/2] hwmon: uniform the init style of pkgtemp |
| |
于 10/2/2010 11:26 AM, Guenter Roeck 写道: > On Sun, Sep 26, 2010 at 05:59:59AM -0000, Chen Gong wrote: >> pkgtemp is derived from coretemp, so some reasonable >> logics should be applied onto pkgtemp, too. Such as >> the init logic here. >> >> Signed-off-by: Chen Gong<gong.chen@linux.intel.com> >> Acked-by: Jan Beulich<jbeulich@novell.com> >> > Hi, > > this patch, when applied with CONFIG_HOTPLUG_CPU undefined, causes a compile failure > because it tries to access pkgtemp_cpu_notifier which is not defined in this case. > > For that reason, I have removed the patch from the list of applied patches for -next. > Please re-submit a version which compiles for all combinations of HOTPLUG_CPU and SMP > defined/undefined. > > Thanks, > Guenter > Sorry for late. I just come back from my holiday. If only this one patch is applied, it is broken, but it will be OK after these 2 patches are applied. I tested the patches when CONFIG_SMP is undefined, it does be broken again. My suggestion is adding a macro definiton in the pkgtemp.c like "#include <asm/smp.h>". If it is doable, I will re-post a new patch series -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |