Messages in this thread | | | Date | Thu, 7 Oct 2010 10:01:12 -0400 | From | Don Zickus <> | Subject | Re: [RFC] arch generic way to trigger unknown NMIs |
| |
On Thu, Oct 07, 2010 at 09:26:41AM +0200, Andi Kleen wrote: > > Having a regression test for this is good, but it would > be also good if it wasn't a private one but in some public > git repository.
Yeah, I know. It isn't meant to be private, mostly glue logic to load this module using RedHat's internal test harness.
Is there a more public place to add a test like this? I guess that would be LTP. Though last time I looked at LTP, all the tests are written in 'C' whereas I just cobbled together some shell scripts to configure kdump, load the module, panic, process the resulting vmcore to verify it panic'd for the right reason.
> > > static struct jprobe lkdtm; > > @@ -340,6 +343,9 @@ static void lkdtm_do_action(enum ctype which) > > set_current_state(TASK_UNINTERRUPTIBLE); > > schedule(); > > break; > > + case NMI: > > + apic->send_IPI_allbutself(NMI_VECTOR); > > + break; > > case NONE: > > default: > > break; > > > > Anyone have any thoughts? Maybe there is an easier way? > > Do you really want the NMI on all CPUs - 1? Normally it's directed to > a single one.
No I prefer a single one too, but there didn't seem to be a send_IPI_self() command, so I took the short route and sent it to everyone. :-(
Cheers, Don
> > -Andi
| |