lkml.org 
[lkml]   [2010]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/5] jump label: fix module __init section race
    (2010/10/07 0:46), Steven Rostedt wrote:
    > On Wed, 2010-10-06 at 11:41 -0400, Jason Baron wrote:
    >> On Wed, Oct 06, 2010 at 09:00:50AM -0400, Steven Rostedt wrote:
    >>> On Sat, 2010-10-02 at 17:58 +0900, Masami Hiramatsu wrote:
    >>>
    >>>>> +static void remove_module_init(struct module *mod)
    >>>>
    >>>> Hi Jason,
    >>>>
    >>>> Just a comment, I prefer remove_jump_label_module_init() than this name,
    >>>> because remove_module_init is too general.
    >>>
    >>> This is probably not too big of a deal since it is static, but the name
    >>> change may make it easier for etags and ctags users.
    >>>
    >>> Jason, are you OK if I pull in this patch and make the change myself?
    >>>
    >>> -- Steve
    >>>
    >>
    >> fine with me. I had a more specific function name and then shortened it
    >> because it seemed too long, either way is fine with me.
    >>
    >
    > Maybe call it jl_remove_module_init()? For static functions, I usually
    > use abbreviations. As long as it isn't too confusing.
    >

    Ah, that's fine for me too :)

    --
    Masami HIRAMATSU
    2nd Dept. Linux Technology Center
    Hitachi, Ltd., Systems Development Laboratory
    E-mail: masami.hiramatsu.pt@hitachi.com


    \
     
     \ /
      Last update: 2010-10-07 03:59    [W:0.033 / U:14.876 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site