lkml.org 
[lkml]   [2010]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [V9fs-developer] [PATCH 3/3] fs/9p: Use generic_file_open with lookup_instantiate_filp
On 10/5/2010 10:01 AM, Aneesh Kumar K.V wrote:
> We need to do O_LARGEFILE check even in case of 9p. Use the
> generic_file_open helper
>
> Signed-off-by: Aneesh Kumar K.V<aneesh.kumar@linux.vnet.ibm.com>

Looks good to me

Reviewed by : Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>

> ---
> fs/9p/vfs_inode.c | 11 ++---------
> 1 files changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c
> index 1ac9229..44ce77d 100644
> --- a/fs/9p/vfs_inode.c
> +++ b/fs/9p/vfs_inode.c
> @@ -560,13 +560,6 @@ static int v9fs_remove(struct inode *dir, struct dentry *file, int rmdir)
> return retval;
> }
>
> -static int
> -v9fs_open_created(struct inode *inode, struct file *file)
> -{
> - return 0;
> -}
> -
> -
> /**
> * v9fs_create - Create a file
> * @v9ses: session information
> @@ -766,7 +759,7 @@ v9fs_vfs_create_dotl(struct inode *dir, struct dentry *dentry, int omode,
>
> /* if we are opening a file, assign the open fid to the file */
> if (nd&& nd->flags& LOOKUP_OPEN) {
> - filp = lookup_instantiate_filp(nd, dentry, v9fs_open_created);
> + filp = lookup_instantiate_filp(nd, dentry, generic_file_open);
> if (IS_ERR(filp)) {
> p9_client_clunk(ofid);
> return PTR_ERR(filp);
> @@ -825,7 +818,7 @@ v9fs_vfs_create(struct inode *dir, struct dentry *dentry, int mode,
>
> /* if we are opening a file, assign the open fid to the file */
> if (nd&& nd->flags& LOOKUP_OPEN) {
> - filp = lookup_instantiate_filp(nd, dentry, v9fs_open_created);
> + filp = lookup_instantiate_filp(nd, dentry, generic_file_open);
> if (IS_ERR(filp)) {
> err = PTR_ERR(filp);
> goto error;




\
 
 \ /
  Last update: 2010-10-06 01:33    [from the cache]
©2003-2011 Jasper Spaans