Messages in this thread | | | Date | Sat, 30 Oct 2010 21:21:31 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 1/2] perf bench: port memcpy_64.S to perf bench |
| |
* Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> On Sat, 2010-10-30 at 01:01 +0900, Hitoshi Mitake wrote: > > This patch ports arch/x86/lib/memcpy_64.S to "perf bench mem". > > When PERF_BENCH is defined at preprocessor level, > > memcpy_64.S is preprocessed to includable form from the sources > > under tools/perf for benchmarking programs. > > > > Signed-off-by: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp> > > Cc: Ma Ling: <ling.ma@intel.com> > > Cc: Zhao Yakui <yakui.zhao@intel.com> > > Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> > > Cc: Arnaldo Carvalho de Melo <acme@redhat.com> > > Cc: Paul Mackerras <paulus@samba.org> > > Cc: Frederic Weisbecker <fweisbec@gmail.com> > > Cc: Steven Rostedt <rostedt@goodmis.org> > > Cc: Thomas Gleixner <tglx@linutronix.de> > > Cc: H. Peter Anvin <hpa@zytor.com> > > --- > > arch/x86/lib/memcpy_64.S | 30 ++++++++++++++++++++++++++++++ > > 1 files changed, 30 insertions(+), 0 deletions(-) > > > > diff --git a/arch/x86/lib/memcpy_64.S b/arch/x86/lib/memcpy_64.S > > index 75ef61e..72c6dfe 100644 > > --- a/arch/x86/lib/memcpy_64.S > > +++ b/arch/x86/lib/memcpy_64.S > > @@ -1,10 +1,23 @@ > > /* Copyright 2002 Andi Kleen */ > > > > +/* > > + * perf bench adoption by Hitoshi Mitake > > + * PERF_BENCH means that this file is included from > > + * the source files under tools/perf/ for benchmark programs. > > + * > > + * You don't have to care about PERF_BENCH when > > + * you are working on the kernel. > > + */ > > + > > +#ifndef PERF_BENCH > > I don't like littering the actual kernel code with tools/perf/ > ifdeffery..
Yeah - could we somehow accept that file into a perf build as-is?
Thanks,
Ingo
| |