lkml.org 
[lkml]   [2010]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/2] jump label: disable due to compiler bug
From
Date
On Fri, 2010-10-29 at 11:13 -0700, Richard Henderson wrote:
> On 10/29/2010 10:48 AM, David Daney wrote:
> > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46226
> >
> > Perhaps it could be integrated with the current checks for the presence of 'asm goto'
>
> If you're looking for a cross-compile-able test, you can strip the
> testcase down to
>
> extern void abort(void);
> void g(int x, ...);
> void f(int x)
> {
> if (x == 0)
> g(0);
> g(1, 2, 3, 4, 5, 6, 7);
> asm goto ("XYZZY" : : : : label);
> abort ();
> label:
> return;
> }
>
> and use perl to notice the adjustment to esp before or after XYZZY.
> It should be fairly obvious looking at the assembly before and after
> the patch.
>
> I don't know what sort of embedded processors supported by linux
> actually use ACCUMULATE_OUTGOING_ARGS. Almost all ports don't, so
> I'd be pretty comfortable making this a 32-bit x86 only test, and
> let other targets just check that the test compiles.
>

Thanks! I'll make a patch with this check (for x86_32) and queue it up
for 2.6.38. I think we are way past doing this for 2.6.37.

-- Steve




\
 
 \ /
  Last update: 2010-10-29 20:29    [from the cache]
©2003-2011 Jasper Spaans