Messages in this thread | | | Subject | Re: [PATCH 2/2] jump label: disable due to compiler bug | From | Steven Rostedt <> | Date | Fri, 29 Oct 2010 12:18:28 -0400 |
| |
On Fri, 2010-10-29 at 09:35 -0400, Mathieu Desnoyers wrote: > * Steven Rostedt (rostedt@goodmis.org) wrote:
> > Then in the code have: > > > > -#if defined(CC_HAVE_ASM_GOTO) && defined(CONFIG_HAVE_ARCH_JUMP_LABEL) > > +#if defined(CC_HAVE_ASM_GOTO) && defined(CONFIG_HAVE_ARCH_JUMP_LABEL) \ > > Technically, you could remove the dependency on > "defined(CONFIG_HAVE_ARCH_JUMP_LABEL)", because it is now dealt with at > the Kconfig level (CONFIG_JUMP_LABEL depends on it).
Yeah, I noticed that just after hitting send.
> > > + && defined(JUMP_LABEL) > > this would be defined(CONFIG_JUMP_LABEL)
Yep, this too, but thanks for pointing it out.
> > The rest looks fine,
Great, can I add your acked-by then?
-- Steve
| |