lkml.org 
[lkml]   [2010]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH -V22 06/14] fs: Don't allow to create hardlink for deleted file
    Date
    Add inode->i_nlink == 0 check in VFS. Some of the file systems
    do this internally. A followup patch will remove those instance.
    This is needed to ensure that with link by handle we don't allow
    to create hardlink of an unlinked file. The check also prevent a race
    between unlink and link

    Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
    ---
    fs/namei.c | 6 +++++-
    1 files changed, 5 insertions(+), 1 deletions(-)

    diff --git a/fs/namei.c b/fs/namei.c
    index ea6656e..9c8d4cc 100644
    --- a/fs/namei.c
    +++ b/fs/namei.c
    @@ -2620,7 +2620,11 @@ int vfs_link(struct dentry *old_dentry, struct inode *dir, struct dentry *new_de
    return error;

    mutex_lock(&inode->i_mutex);
    - error = dir->i_op->link(old_dentry, dir, new_dentry);
    + /* Make sure we don't allow creating hardlink to an unlinked file */
    + if (inode->i_nlink == 0)
    + error = -ENOENT;
    + else
    + error = dir->i_op->link(old_dentry, dir, new_dentry);
    mutex_unlock(&inode->i_mutex);
    if (!error)
    fsnotify_link(dir, inode, new_dentry);
    --
    1.7.1


    \
     
     \ /
      Last update: 2010-10-29 12:01    [W:0.021 / U:38.236 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site