Messages in this thread | | | Subject | Re: How do I add yaffs file system to mainline? | From | Joe Perches <> | Date | Thu, 28 Oct 2010 11:29:18 -0700 |
| |
On Thu, 2010-10-28 at 11:08 -0700, Greg KH wrote: > On Fri, Oct 29, 2010 at 06:55:39AM +1300, Charles Manning wrote: > > I know there is a style guide etc, but when we're talking about processing 15k > > loc then some of those rules might be slightly bendable. > > Not really. > > Have you run it through sparse and scripts/checkpatch.pl? If not, > please do so and resolve all of the issues that they bring up.
I wouldn't do that. Checkpatch is useful but frequently wrong. By all means do use checkpatch, but please use your own taste to determine what you think needs fixing.
| |