lkml.org 
[lkml]   [2010]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 01/12] misc: add driver for sequencer serial port
On 10/28/2010 11:49 AM, Linus Walleij wrote:
> 2010/10/26 Cyril Chemparathy <cyril@ti.com>:
>
>> TI's sequencer serial port (TI-SSP) is a jack-of-all-trades type of serial port
>> device. It has a built-in programmable execution engine that can be programmed
>> to operate as almost any serial bus (I2C, SPI, EasyScale, and others).
>>
>> This patch adds a driver for this controller device. The driver does not
>> expose a user-land interface. Protocol drivers built on top of this layer are
>> expected to remain in-kernel.
>
> Why is this thing in drivers/misc?
>
> drivers/mfd is IMHO the apropriate place for a driver like this, and
> the subdrivers should be migrated to use mfd cells and platform
> drivers for the subdevices.
>
> All functions and abstractions you create here look suspiciously
> lot like other MFD devices.
>
> But please, beat me up if I'm wrong!

Alan had raised the same concern earlier, and my response was:

> Unlike MFDs, this device doesn't have cells with differing
> functionality. Instead it has functionally identical ports that can
> operate in a variety of modes. That said, does this still fit in with
> other MFD drivers? If so, I don't see a problem with moving it there.

I don't see a problem with moving this into MFD, but this won't be able
to use any of the functionality provided by mfd-core.

Thanks
Cyril.


\
 
 \ /
  Last update: 2010-10-28 18:13    [W:0.109 / U:5.240 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site