Messages in this thread | | | Date | Wed, 27 Oct 2010 13:38:50 -0700 | From | Ben Greear <> | Subject | Re: [PATCH] pktgen: Remove a dangerous debug print. |
| |
On 10/27/2010 12:13 PM, Nelson Elhage wrote: > We were allocating an arbitrarily-large buffer on the stack, which would allow a > buggy or malicious userspace program to overflow the kernel stack. > > Since the debug printk() was just printing exactly the text passed from > userspace, it's probably just as easy for anyone who might use it to augment (or > just strace(1)) the program writing to the pktgen file, so let's just not bother > trying to print the whole buffer.
Maybe just allocate that buffer on the heap instead of stack?
Thanks, Ben
-- Ben Greear <greearb@candelatech.com> Candela Technologies Inc http://www.candelatech.com
| |