Messages in this thread | | | Date | Wed, 27 Oct 2010 19:44:17 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH] x86: use pgd accessors when cloning a pgd range. |
| |
On Wed, Oct 27, 2010 at 10:31:37AM -0700, Jeremy Fitzhardinge wrote: > > Xen shouldn't have any users of this, since it's used for low-level > > operations like SMP bootstrap, suspend to RAM, reboot and low-level > > BIOS functionality. > > > Right, but it is being called smack in the middle of setup_arch(). It > looks like they could be hidden away in > native_pagetable_setup_start/done though.
I think I can put the second sync-back clone_pgd_range in native_pagetable_setup_done but the first one needs to take place right at the beginning of setup_arch() because a lot of code in-between relies on swapper_pg_dir containing proper entries.
Just to make sure I understand you correctly: best it would be for xen to not have the copy_pgd_range() calls in setup_arch, correct?
-- Regards/Gruss, Boris.
| |