Messages in this thread | | | Date | Wed, 27 Oct 2010 10:59:47 -0400 | From | "Emilio G. Cota" <> | Subject | Re: [PATCH 24/30] staging/vme_user: remove unnecessary call to vme_slave_set |
| |
On Wed, Oct 27, 2010 at 13:24:55 +0100, Martyn Welch wrote: > On 26/10/10 02:11, Emilio G. Cota wrote: > > From: Emilio G. Cota <cota@braap.org> > > > > The resource is about to be freed and therefore it is pointless to > > set any of its parameters. > > Nope - this is disabling the window, which given that you are about to > unalloc the memory that it is using this is quite important.
Aah I didn't realise that
> > - vme_slave_set(image[i].resource, 0, 0, 0, 0, VME_A32, 0);
disables the window. I thought vme_slave_free would disable it as well. Forget this one, then.
Thanks
Emilio
| |