lkml.org 
[lkml]   [2010]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 24/30] staging/vme_user: remove unnecessary call to vme_slave_set
On 26/10/10 02:11, Emilio G. Cota wrote:
> From: Emilio G. Cota <cota@braap.org>
>
> The resource is about to be freed and therefore it is pointless to
> set any of its parameters.

Nope - this is disabling the window, which given that you are about to
unalloc the memory that it is using this is quite important.

Martyn

>
> Signed-off-by: Emilio G. Cota <cota@braap.org>
> ---
> drivers/staging/vme/devices/vme_user.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c
> index 95c22ff..a1cb85b 100644
> --- a/drivers/staging/vme/devices/vme_user.c
> +++ b/drivers/staging/vme/devices/vme_user.c
> @@ -851,7 +851,6 @@ static int __devexit vme_user_remove(struct device *dev, int cur_bus, int cur_sl
> kfree(image[i].kern_buf);
>
> for (i = SLAVE_MINOR; i < (SLAVE_MAX + 1); i++) {
> - vme_slave_set(image[i].resource, 0, 0, 0, 0, VME_A32, 0);
> buf_unalloc(i);
> vme_slave_free(image[i].resource);
> }


--
Martyn Welch (Principal Software Engineer) | Registered in England and
GE Intelligent Platforms | Wales (3828642) at 100
T +44(0)127322748 | Barbirolli Square,
Manchester,
E martyn.welch@ge.com | M2 3AB VAT:GB 927559189


\
 
 \ /
  Last update: 2010-10-27 14:29    [W:0.279 / U:0.464 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site